Small bug preventing from approving in French sites/variations (SharePoint)

One of my co-worker, Philippe Bédard, found a little bug last week that was preventing users to approve images in a French publishing web site. Basically, if you use the "View All Site" and navigate to a library that contains unapproved items, the contextual menu will show a "Approve" button.  This button will take you to a page that contains a JavaScript to confirm your action.

Problem is, in French, the text (from a resource file) contains an apostrophe (') without encoding it for Javascript (\').  The Javascript simply breaks and the button doesn't fire.  Luckily, you can approve from a different page through the Manage Content and Structure button and approve from there.  The page that uses that resource is "_layouts/approve.aspx".

 

To fix the issue temporarily (until we have an official fix, otherwise, the resource file can be replaced by any fix/service pack), you can modify the wss.fr-fr.resx file that is contained in the 12 hive (12\Config\Resources) directory as well as any web site's App_GlobalResources directories.  Look for the "approve_canleWorkflow_alert" (yes, typo there in the resource file, even better :)) and update the apostrophe.  Here's what the resource file looks like :

 

Original version:

<data name="approve_CancleWorkflow_alert">

        <value>Un flux de travail d'approbation du contenu est actuellement exécuté pour approuver cet élément. Si vous poursuivez cette opération, le flux de travail sera annulé.</value>

</data>

 

Fixed version:

<data name="approve_CancleWorkflow_alert">

        <value>Un flux de travail d\'approbation du contenu est actuellement exécuté pour approuver cet élément. Si vous poursuivez cette opération, le flux de travail sera annulé.</value>

</data>

 

Thanks Philippe !

 

 

Maxime