What's wrong with this code sample...
Today, Michael Howard posted a link to updated documentation that contains the new list of banned APIs that is in place for Windows Vista.
This is GREAT, and I'm really glad to see it - we've excised all of these functions from our code, others should do it as well.
But then as I was reading through the article, I noticed this code in the example of how to fix a function that uses strcpy:
HRESULT Function(char *s1, char *s2) {
char temp[32];
HRESULT hr = StringCchCopy(temp,sizeof(temp),s1);
if (FAILED(hr)) return hr;
return StringCchCat(temp,sizeof(temp),s2);
}
Why did I cringe the second I saw this?